(Update/Add) Torrent Views Search #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
singularity43
commented
Jan 17, 2019
singularity43
commented
- Add search to cards view.
- Add on page grouping (similar to other tracker pages), rather than click through.
- Add ability to hide filters ( as discussed with @HDVinnie )
- Add search to groupings view.
- Add Helper JS file for future helper type functions.
- Remove unused views.
Updates initial states for torrents(), cards(). Removes nuked groupingCategories() and groupingResults(). Adds scraping to controller, instead of views. Adds on page grouping (rather than clicking through). This was a big push, so there may be some issues. Please review. Also, there are some unused attributes/vars. I left some in and 1 line of faulty logic (redudant) because I am planning to revisit this soon.
Helper JS for common functions for torrent search/view. Will place any other helpers I think of here.
Add support for filters/groupings.
Add card hacks to clean up grouping layout (so it plays nice).
Remove view based movie scraping. Refactor layout/etc to work with new search enabled view.
No longer needed.
No longer needed.
No longer needed.
Change to faceted type groupings. Also on page groupings instead of click through.
Sort by links (instead of dropdown). Update bookmark inline to work with new helper.
Just a clone job of original view.
Clone job from original
Update to use helper.js, update to add toggable filters.
Add groupings. Change cards. Commented out /torrents/grouping/* ... you can completely remove if you will never readd it.
Remove reference to nuked route.
Load helper Js.
Fixed in grouping view.
Readd groupingResults as renamed similar (as per discussion with Vinnie)
|
Closes #396 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.