(Add) Allow internal options for internals in non-internal group

[Obi-Wana]

Internals that are not member of the internal group (e.g., Editor) and not Moderator+ should still be able to set the internal options on their uploads. They need to be in at least one Internal group, checked using count of InternalUsers.

[what-the-diff]

PR Summary

• Improved User Permission Verification
  Updated the method in which user permissions are checked internally for enhanced security.

• Enhanced Torrent Attribute Setting Mechanism
  Revamped the way how torrent attributes like internal, featured, doubleup, refundable, and free are set, linking it more closely to user permissions.

• Updated User Interface for Input Fields
  Tweaked the visibility rules for input fields on the create.blade.php. This change will make the interface more intuitive and in sync with backend logic.

[Roardom]

Great idea!

Can we use $user->internals()->exists() instead to make it more efficient?

Further, I think we can even drop the is_internal column on the groups table and use this relation as the source of truth instead for all cases the is_internal flag is checked. What do you think @HDVinnie?

[Obi-Wana]

Can we use $user->internals()->exists() instead to make it more efficient?

No, ->exists() does not exist on this, just checked.

Further, I think we can even drop the is_internal column on the groups table and use this relation as the source of truth instead for all cases the is_internal flag is checked. What do you think @HDVinnie?

I'll let this up to you, and think it should be going into its own PR.

[HDVinnie]

LGTM. Just swap the count for exist.

[Roardom]

When using loadExists, you need to specify the relation to load, i.e. ->loadExists('internals'). Then, instead of checking for if $user->internals()->exists(), you only have to check the $user->internals_exists property that's added to the user without needing further database calls.

[Obi-Wana]

When using loadExists, you need to specify the relation to load, i.e. ->loadExists('internals'). Then, instead of checking for if $user->internals()->exists(), you only have to check the $user->internals_exists property that's added to the user without needing further database calls.

Added this to the APIController, but Larastan doesn't seem to like it...

[Roardom]

I checked through the larastan repo and you're right: unfortunately larastan doesn't yet support relation_exists (although it does support relation_count).

Try adding /** @phpstan-ignore property.notFound (Larastan doesn't yet support loadExists()) */ wherever the property is accessed.
Relevant documentation can be found here: https://phpstan.org/user-guide/ignoring-errors

[Roardom]

Can you do a ctrl+f in your IDE for ->group->is_internal and replace all the instances with the ->internals()->exists() logic? (And use eager loading if the query is used multiple times in a single http request).

Thanks!

[Roardom]

Thank you!