(Refactor) Move welcome message to listener and add tests #4296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the logic responsible for sending welcome message to newly registered user into a listener. This makes it much easier to test the registration flow as it no longer depends on
Bot
andChatroom
classes and allows to test that particular logic separately instead.Using event listeners instead of controllers/actions makes it easier to decouple the logic and allows to conditionally run it in the future if needed. It is also easy to mock it using
Event::fake()
in tests.