(Add) Internal notes for staff invitations #4291
Conversation
IonBazan
changed the title
| @@ -93,10 +93,18 @@ public function create(array $input): RedirectResponse | User | |||
| $user->emailUpdates()->create(); | |||
|
|
|||
| if (config('other.invite-only') === true) { | |||
| Invite::where('code', '=', $input['code'])->update([ | |||
| $invite = Invite::where('code', '=', $input['code'])->withoutTrashed()->first(); | |||
There was a problem hiding this comment.
Shouldn't need to do ->withoutTrashed() here. It's only included above because soft deletion isn't considered for Rule::exists() validation.
There was a problem hiding this comment.
Thanks! I wasn't sure why is it used above so made it explicit just in case. Fixed in my next commit.
| <textarea | ||
| id="internal_note" | ||
| class="form__textarea" | ||
| name="internal_note" |
There was a problem hiding this comment.
You might need to add placeholder=" " here for the autoexpand to work in browsers that don't yet support field-sizing: content as well as to get the label to float.
|
@Roardom thanks for the review! I chose a simple task for my first contribution in this repository but I'll try to help with more improvements 🚀 I wasn't sure if |
Thanks for the PR! If I'm going to be honest, UNIT3D is lacking a lot of proper testing. There shouldn't be too many issues with the code though as it follows the same logic as the other items also created upon user creation. All of the attributes are mass assignable and there are no database fields without a default that are omitted. The field is properly validated to only be filled by staff and only shown to staff 👍 . But, I've been known to be wrong before. Regarding Fortify, we've personally had a terrible experience with it and I definitely wouldn't recommend using it if you had a choice. Main reason is all the workarounds we've had to add to it to increase its security (lack of rate limits, timing attacks with emails, user enumeration) and handle our logic with account invitations as well as disabled and banned accounts. We'll probably migrate away from it at some point. But basically, when a user registers using the form which posts to fortify's With regards to testing it, we never had our tests migrated over when switching from laravel/ui. If you wish, you could add a new test covering it, but it'd be beyond the scope of this PR. |
|
Thank you very much for the contribution. 🖖 |
Fixes #4045
Adds an
internal_notefor invitations which will be used to create an internal note when user registers.