(Update) Improve footer performance #4198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function was ran in every view. The problem is for every partial, it was ran again. On pages like /mediahub/persons/x, this function was called 4000+ times because of all the partials, causing redis cache hits to use up more than 75% of the processing time to return the response. Fix by only calling it in the footer explicitly.
HDVinnie
approved these changes
Oct 2, 2024
Roardom
added a commit
to Roardom/UNIT3D
that referenced
this pull request
Feb 20, 2025
Keeps code more organized by not having database queries inside the view. Just learned that these were a thing, and realized in the process why there was the issue with HDInnovations#4198 - it was because it was matching on `*`, i.e. all views, so it would render once for every single view, including each include.
Roardom
added a commit
to Roardom/UNIT3D
that referenced
this pull request
Feb 20, 2025
Keeps code more organized by not having database queries inside the view. Just learned that these were a thing, and realized in the process why there was the issue with HDInnovations#4198 - it was because it was matching on `*`, i.e. all views, so it would render once for every single view, including each include.
Roardom
added a commit
to Roardom/UNIT3D
that referenced
this pull request
Feb 20, 2025
Keeps code more organized by not having database queries inside the view. Just learned that these were a thing, and realized in the process why there was the issue with HDInnovations#4198 - it was because it was matching on `*`, i.e. all views, so it would render once for every single view, including each include.
Roardom
added a commit
to Roardom/UNIT3D
that referenced
this pull request
Feb 20, 2025
Keeps code more organized by not having database queries inside the view. Just learned that these were a thing, and realized in the process why there was the issue with HDInnovations#4198 - it was because it was matching on `*`, i.e. all views, so it would render once for every single view, including each include.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was ran in every view. The problem is for every partial, it was ran again. On pages like /mediahub/persons/x, this function was called 4000+ times because of all the partials, causing redis cache hits to use up more than 75% of the processing time to return the response. Fix by only calling it in the footer explicitly.