Moderation rework #225
Merged
Moderation rework #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MrG01
commented
Mar 17, 2018
MrG01
commented
- Added a postpone section in moderation (Moderating suggetions #57)
- Core logic of approval is now handled by a helper (Moderating suggetions #57)
- Unapproved items can now be deleted (Cannot Delete Torrents #98)
- Unapproved items no longer show in general areas (Moderating suggetions #57)
- Postpone and Reject now have a message option (Moderating suggetions #57)
- Code refactoring
# Conflicts: # app/Http/Controllers/Staff/ModerationController.php # routes/web.php
- Uploader and Staff is now linkable - modals are called from div’s instead of a’s - Added a staff column to Postpone and Reject - Pending only has a delete option, Reject not required. - Reject now has a Postpone option - Address point 2 of issue #57
- Added validator to delete controller - Address issue #98
- Torrent View Helper now becomes Torrent Helper. - This change is needed because the scope of the helper is widen to all aspects of the torrent and not only the view
- Achievements and announcements are no longer handled by the upload function itself - Refer approval to Torrent Helper
- Once approve occurs: - User Progress is altered; - Shout to Shoutbox occurs - Shout to IRC Bot occurs
- Achievements are not done when torrent is anonymous - some code refactoring
# Conflicts: # app/Http/Controllers/Staff/ModerationController.php # routes/web.php
- for requests input() is preferred over get() - some string changes - minor variables fixes - moderation query changes
# Conflicts: # app/Helpers/TorrentHelper.php # app/Http/Controllers/TorrentController.php
# Conflicts: # app/Http/Controllers/Staff/ModerationController.php # app/Http/Controllers/TorrentController.php
- use cache helper and not facade
- remove facades use
- remove unneeded peer and category USE
- remove facades use - fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.