Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 5.6 Shift #181

Merged
merged 6 commits into from
Feb 14, 2018
Merged

Laravel 5.6 Shift #181

merged 6 commits into from
Feb 14, 2018

Conversation

HDVinnie
Copy link
Collaborator

@HDVinnie HDVinnie commented Feb 6, 2018

This pull request includes the changes for upgrading to Laravel 5.6. Feel free to commit any additional changes to the shift-6100 branch.

Before merging, you should:

  • Checkout the shift-6100 branch
  • Review all pull request comments for additional changes
  • Update your dependencies for Laravel 5.6
  • Run composer update (if the pre-scripts fail, add --no-scripts)
  • Thoroughly test your application

If you need help with your upgrade, check out the Shift Human Services or join the Shifty Coders Slack room to get answers to all your Laravel questions.

The Laravel framework adopts the PSR-2 coding style in version 5.1.
Laravel apps *should* adopt this coding style as well. Read the
[PSR-2 coding style guide][1] for more details and check out [PHPCS][2]
to use as a code formatting tool.

[1]: https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md
[2]: https://github.com/squizlabs/PHP_CodeSniffer
@HDVinnie
Copy link
Collaborator Author

HDVinnie commented Feb 6, 2018

❌ Shift could not upgrade tests/CreatesApplication.php. You will need to compare yours against the 5.6 version and merge any new changes.

@HDVinnie
Copy link
Collaborator Author

HDVinnie commented Feb 6, 2018

⚠ Shift could not upgrade the following project files since they differed from the default Laravel version. You should compare these project files against the default Laravel 5.6 versions and merge any changes:

  • .env.example

@HDVinnie
Copy link
Collaborator Author

HDVinnie commented Feb 6, 2018

❌ Shift could not upgrade the following configuration files since they differed from the default Laravel version. You will need to compare these configuration files against the Laravel 5.6 configuration files and merge any changes:

  • config/app.php
  • config/auth.php
  • config/broadcasting.php
  • config/cache.php
  • config/database.php
  • config/filesystems.php
  • config/mail.php
  • config/queue.php
  • config/services.php
  • config/session.php
  • config/view.php

@HDVinnie
Copy link
Collaborator Author

HDVinnie commented Feb 6, 2018

ℹ Laravel 5.6 introduced a logging configuration file. You should ensure the log and log_level settings previously in the config/app.php are now set in config/logging.php.

@HDVinnie
Copy link
Collaborator Author

HDVinnie commented Feb 6, 2018

❌ Laravel 5.6 requires PHP 7.1.3. You have a modified dependency for PHP in your composer.json. Ensure it meets the new version requirement of >=7.1.3.

@HDVinnie
Copy link
Collaborator Author

HDVinnie commented Feb 6, 2018

⚠ Since Laravel 5.6 has not officially been released, Shift set your dependency to dev-develop. Once Laravel 5.6 is released, you should set your dependency for laravel/framework to 5.6.*.

@HDVinnie
Copy link
Collaborator Author

HDVinnie commented Feb 6, 2018

ℹ All of the underlying Symfony components used by Laravel have been upgraded to Symfony 4.0. If you are directly interacting with Symfony components, you should review the Symfony change log and update your application accordingly.

@HDVinnie
Copy link
Collaborator Author

HDVinnie commented Feb 6, 2018

ℹ The previously deprecated optimize Artisan command has been removed. With recent improvements to PHP itself including the OPcache, the optimize command no longer provides any relevant performance benefit.

@HDVinnie
Copy link
Collaborator Author

HDVinnie commented Feb 6, 2018

ℹ In Laravel 5.6, Blade will double encode special characters by default. If you would like to maintain the previous behavior of preventing double encoding, you may add Blade::withoutDoubleEncoding() to your AppServiceProvider boot method.

@HDVinnie
Copy link
Collaborator Author

HDVinnie commented Feb 6, 2018

ℹ Laravel 5.6 uses Bootstrap 4 by default. Shift did not update your front-end resources or dependencies as this could impact your UI. If you are using Bootstrap and wish to continue using Bootstrap 3, you should add Paginator::useBootstrapThree() to your AppServiceProvider boot method.

@HDVinnie
Copy link
Collaborator Author

HDVinnie commented Feb 6, 2018

ℹ If you have manually upgraded your app from previous versions of Laravel, you should run the Laravel Linter to ensure your app is fully upgraded to the latest version of Laravel.

@HDVinnie
Copy link
Collaborator Author

will move to Argon2 password hashing with this PR. Also will make UNIT3D require PHP 7.2.0 or greater.

HDVinnie added a commit that referenced this pull request Feb 14, 2018
- Preparing for Laravel 5.6 PR
@HDVinnie HDVinnie merged commit 5613acc into master Feb 14, 2018
@HDVinnie HDVinnie deleted the shift-6100 branch February 14, 2018 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants