Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: Allow configuring of echo-server address #1476

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

leighmacdonald
Copy link
Contributor

Enables custom laravel-echo-server address without hard coding. Uses .env config.

@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #1476 into master will decrease coverage by 0.71%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1476      +/-   ##
============================================
- Coverage     25.42%   24.71%   -0.72%     
  Complexity     4491     4491              
============================================
  Files           342      342              
  Lines         14192    14192              
============================================
- Hits           3609     3507     -102     
- Misses        10583    10685     +102     
Impacted Files Coverage Δ Complexity Δ
app/Jobs/ProcessMassPM.php 0.00% <0.00%> (-100.00%) 2.00% <0.00%> (ø%)
app/Notifications/NewFollow.php 0.00% <0.00%> (-100.00%) 3.00% <0.00%> (ø%)
app/Services/Tmdb/TMDB.php 0.00% <0.00%> (-77.78%) 11.00% <0.00%> (ø%)
app/Jobs/ProcessMovieJob.php 0.00% <0.00%> (-70.28%) 10.00% <0.00%> (ø%)
app/Models/Genre.php 0.00% <0.00%> (-50.00%) 2.00% <0.00%> (ø%)
app/Models/Company.php 0.00% <0.00%> (-50.00%) 2.00% <0.00%> (ø%)
app/Services/Tmdb/TMDBScraper.php 2.27% <0.00%> (-36.37%) 13.00% <0.00%> (ø%)
app/Services/Tmdb/Client/Person.php 0.00% <0.00%> (-25.72%) 15.00% <0.00%> (ø%)
app/Models/Cast.php 0.00% <0.00%> (-25.00%) 4.00% <0.00%> (ø%)
app/Models/Crew.php 0.00% <0.00%> (-25.00%) 4.00% <0.00%> (ø%)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa63b58...bde0945. Read the comment docs.

@HDVinnie
Copy link
Collaborator

Ill merge this soon. Have to update installer stub at same time so no conflicts.

@HDVinnie HDVinnie merged commit 26e2488 into HDInnovations:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants