Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Refactor) Types System #1360

Merged
merged 15 commits into from
May 27, 2020
Merged

(Refactor) Types System #1360

merged 15 commits into from
May 27, 2020

Conversation

HDVinnie
Copy link
Collaborator

HDVinnie added 11 commits May 18, 2020 22:57
@HDVinnie
add: new migration
52d2e35 
- this new migration fixes the torrent table column from `type` to `type_id`.
- this column should be filled with the type id and not type name as previously done.
- this migration is backwards compatible and will update existing UNIT3D torrents in the foreach loop.
@HDVinnie
Merge branch 'master' into Types-System-Refactor
21db1f0
@HDVinnie
update: torrent factory
f0eb5f3
@HDVinnie
update: api torrent controller test
57f273b
@HDVinnie
fix: api torrent controller test
fb7c4ac
@HDVinnie
update: view blades
5bc20e4
@HDVinnie
update: queries
3d3de56
@HDVinnie
update: types database seeder
dbdff8b
@HDVinnie
Merge branch 'master' into Types-System-Refactor
2111aa1
@HDVinnie
update: view blades
29cb6c3
@HDVinnie
update: torrent types
ee85ab1
@codecov
Copy link

codecov bot commented May 26, 2020 •
edited
Loading

Codecov Report

Merging #1360 into master will increase coverage by 0.44%.
The diff coverage is 20.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1360      +/-   ##
============================================
+ Coverage     25.90%   26.35%   +0.44%     
  Complexity     4246     4246              
============================================
  Files           304      304              
  Lines         13353    13353              
============================================
+ Hits           3459     3519      +60     
+ Misses         9894     9834      -60
Impacted Files Coverage Δ Complexity Δ
app/Helpers/TorrentHelper.php 60.00% <0.00%> (+60.00%) 10.00 <0.00> (ø)
app/Http/Controllers/GraveyardController.php 0.00% <0.00%> (ø) 28.00 <0.00> (ø)
app/Http/Controllers/RequestController.php 0.00% <0.00%> (ø) 90.00 <0.00> (ø)
app/Http/Controllers/RssController.php 0.00% <0.00%> (ø) 61.00 <0.00> (ø)
...pp/Http/Controllers/Staff/ModerationController.php 0.00% <0.00%> (ø) 9.00 <0.00> (ø)
app/Http/Controllers/TorrentController.php 0.00% <0.00%> (ø) 336.00 <0.00> (ø)
app/Http/Controllers/UserController.php 0.00% <0.00%> (ø) 460.00 <0.00> (ø)
app/Http/Controllers/API/TorrentController.php 66.80% <66.66%> (+6.80%) 108.00 <0.00> (ø)
app/Http/Controllers/CategoryController.php 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
app/Http/Controllers/HomeController.php 98.76% <100.00%> (ø) 3.00 <0.00> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3981b8d...fc07c3e. Read the comment docs.

@HDVinnie HDVinnie merged commit 33b9f85 into master May 27, 2020
@HDVinnie HDVinnie deleted the Types-System-Refactor branch May 27, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement Refactor Review WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Torrent types name change
1 participant
@HDVinnie