Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Update) Subtitles System #1341

Merged
merged 2 commits into from
May 15, 2020
Merged

(Update) Subtitles System #1341

merged 2 commits into from
May 15, 2020

Conversation

PyR8zdl
Copy link
Contributor

@PyR8zdl PyR8zdl commented May 14, 2020

  1. Fixed typo in return route. Reverted.
  2. Made the use of filesystem consistent.
  3. Removed unneeded copy to tmp directory.
  4. Simplified mime-type and file return.

1. Fixed typo in return route.
2. Made the use of filesystem consistent.
3. Removed unneeded copy to tmp directory.
4. Simplified mime-type and file return.
@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #1341 into master will decrease coverage by 0.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1341      +/-   ##
============================================
- Coverage     26.05%   25.89%   -0.16%     
+ Complexity     4225     4223       -2     
============================================
  Files           299      299              
  Lines         13276    13271       -5     
============================================
- Hits           3459     3437      -22     
- Misses         9817     9834      +17     
Impacted Files Coverage Δ Complexity Δ
app/Http/Controllers/SubtitleController.php 0.00% <0.00%> (ø) 23.00 <0.00> (-2.00)
app/Jobs/ProcessMassPM.php 0.00% <0.00%> (-100.00%) 2.00% <0.00%> (ø%)
...pp/Http/Controllers/Staff/MassActionController.php 60.00% <0.00%> (-6.67%) 6.00% <0.00%> (ø%)
app/Models/User.php 37.69% <0.00%> (-3.97%) 122.00% <0.00%> (ø%)
app/Repositories/ChatRepository.php 67.66% <0.00%> (-3.60%) 47.00% <0.00%> (ø%)
app/Http/Controllers/CommentController.php 77.03% <0.00%> (-1.49%) 46.00% <0.00%> (ø%)
app/Http/Controllers/AnnounceController.php 45.27% <0.00%> (ø) 66.00% <0.00%> (ø%)
app/Http/Controllers/FollowController.php 77.77% <0.00%> (+3.70%) 7.00% <0.00%> (ø%)
app/Notifications/NewUnfollow.php 100.00% <0.00%> (+100.00%) 3.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7de8989...603934c. Read the comment docs.

@HDVinnie HDVinnie changed the title Subtitle-System Patch (Update) Subtitles System May 15, 2020
@HDVinnie HDVinnie merged commit e697042 into HDInnovations:master May 15, 2020
howardlau1999 pushed a commit to sysu-ipv6/UNIT3D-Community-Edition that referenced this pull request Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants