Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Refactoring) Topic Controller: fix query n + 1 problem #1315

Merged
merged 1 commit into from
Apr 26, 2020

Conversation

VictoRD11
Copy link

New PR, Topic Controller n+1

@HDVinnie
Copy link
Collaborator

HDVinnie commented Apr 26, 2020

Great refactors here. Thank you for the contributions @VictoRD11

@codecov
Copy link

codecov bot commented Apr 26, 2020

Codecov Report

Merging #1315 into master will decrease coverage by 0.64%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1315      +/-   ##
============================================
- Coverage     26.62%   25.97%   -0.65%     
  Complexity     4218     4218              
============================================
  Files           300      300              
  Lines         13247    13250       +3     
============================================
- Hits           3527     3442      -85     
- Misses         9720     9808      +88     
Impacted Files Coverage Δ Complexity Δ
app/Http/Controllers/TopicController.php 0.00% <0.00%> (ø) 23.00 <0.00> (ø)
app/Services/Data/Tv.php 0.00% <0.00%> (-83.34%) 5.00% <0.00%> (ø%)
app/Services/Clients/TmdbClient.php 4.65% <0.00%> (-33.96%) 89.00% <0.00%> (ø%)
app/Services/MovieScrapper.php 55.55% <0.00%> (-27.78%) 10.00% <0.00%> (ø%)
app/Services/Clients/Client.php 62.06% <0.00%> (-24.14%) 15.00% <0.00%> (ø%)
app/Services/Data/Movie.php 17.46% <0.00%> (-11.12%) 40.00% <0.00%> (ø%)
app/Http/Controllers/API/TorrentController.php 60.85% <0.00%> (-0.86%) 108.00% <0.00%> (ø%)
app/Models/User.php 41.66% <0.00%> (+1.98%) 122.00% <0.00%> (ø%)
app/Repositories/ChatRepository.php 71.25% <0.00%> (+3.59%) 47.00% <0.00%> (ø%)
app/Models/Torrent.php 23.94% <0.00%> (+4.22%) 32.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82719e8...9c44fdd. Read the comment docs.

@HDVinnie HDVinnie merged commit cc12dc4 into HDInnovations:master Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants