Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) WishController.php #1311

Merged
merged 1 commit into from
Apr 26, 2020
Merged

Conversation

innocente205
Copy link
Contributor

Check for IMDB entry to avoid 500 error

Check for IMDB entry to avoid 500 error
@codecov
Copy link

codecov bot commented Apr 26, 2020

Codecov Report

Merging #1311 into master will increase coverage by 0.55%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1311      +/-   ##
============================================
+ Coverage     26.23%   26.78%   +0.55%     
- Complexity     4218     4219       +1     
============================================
  Files           300      300              
  Lines         13245    13249       +4     
============================================
+ Hits           3475     3549      +74     
+ Misses         9770     9700      -70     
Impacted Files Coverage Δ Complexity Δ
app/Http/Controllers/WishController.php 0.00% <0.00%> (ø) 10.00 <0.00> (+1.00)
app/Jobs/ProcessMassPM.php 0.00% <0.00%> (-100.00%) 2.00% <0.00%> (ø%)
app/Services/MovieScrapper.php 61.11% <0.00%> (-22.23%) 10.00% <0.00%> (ø%)
...pp/Http/Controllers/Staff/MassActionController.php 60.00% <0.00%> (-6.67%) 6.00% <0.00%> (ø%)
app/Models/User.php 40.47% <0.00%> (-2.78%) 122.00% <0.00%> (ø%)
app/Http/Controllers/API/TorrentController.php 60.85% <0.00%> (-0.86%) 108.00% <0.00%> (ø%)
app/Helpers/StringHelper.php 16.00% <0.00%> (+2.00%) 41.00% <0.00%> (ø%)
app/Services/Data/Movie.php 33.33% <0.00%> (+15.87%) 40.00% <0.00%> (ø%)
app/Services/Clients/Client.php 86.20% <0.00%> (+24.13%) 15.00% <0.00%> (ø%)
app/Services/Clients/TmdbClient.php 39.53% <0.00%> (+32.55%) 89.00% <0.00%> (ø%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b97ecb5...7ba0178. Read the comment docs.

@HDVinnie
Copy link
Collaborator

Im going to merge this for now. In the end the wish system needs to be refactored though. We only use TMDB anymore.

@HDVinnie HDVinnie merged commit 9fec05c into HDInnovations:master Apr 26, 2020
@innocente205 innocente205 deleted the patch-1 branch April 27, 2020 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants