(Add) Subtitle System #1256
Merged
(Add) Subtitle System #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
HDVinnie
commented
Mar 30, 2020
HDVinnie
commented
- this PR contain the new subtitles system which closes Subtitle system #730
- media languages are used to populate languages dropdowns for things like subtitles, audios, etc. Media Languages was chosen to not conflict or be confused with the already use Languages which is used for site multilangual support.
- eager load torrent subtitles
- add subtitles block
- increment downloads counter
- display what subtitles are already muxed into the torrent based off mediainfo input
[ci skip] [skip ci]
Apply fixes from StyleCI
Codecov Report
@@ Coverage Diff @@
## master #1256 +/- ##
=========================================
Coverage 28.26% 28.26%
Complexity 4257 4257
=========================================
Files 300 300
Lines 13545 13545
=========================================
Hits 3829 3829
Misses 9716 9716 Continue to review full report at Codecov.
|
|
Just an update that I am adding Subtitle achievements, ability to upload anonymously and tests before merging this. Will be working on it today/tonight. |
|
Would be nice to optionally reward x BON on upload too. |
[ci skip] [skip ci]
Apply fixes from StyleCI
- fix operator
[ci skip] [skip ci]
Apply fixes from StyleCI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.