-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Enhancement) New options on torrent upload api #1247
Conversation
Adds options to set torrent as Featured, DoubleUp, Freeleech, and Sticky on upload api endpoint. I've done limited testing on this and I'm worndering if this could be done better.
Codecov Report
@@ Coverage Diff @@
## master #1247 +/- ##
============================================
- Coverage 26.89% 26.70% -0.19%
- Complexity 4157 4175 +18
============================================
Files 297 297
Lines 13129 13151 +22
============================================
- Hits 3531 3512 -19
- Misses 9598 9639 +41
Continue to review full report at Codecov.
|
Ok, I think I got this mostly tested. I want to test a few more scenarios tomorrow. |
I've tested with all possible options and is working as intended. Hopefully, all the checks pass. 👍 |
It won't pass TravisCI until the test is updated. https://github.com/HDInnovations/UNIT3D-Community-Edition/blob/master/tests/Feature/Http/Controllers/API/TorrentControllerTest.php If you cannot do it then I will this weekend before merging. |
@PyR8zdl I have simplified the if else to ternary and updated the test. Assuming it passes ill merge. |
@HDVinnie Nice, It looks alot better now. In future I will use this format. Thanks! |
Adds options to set torrent as Featured, DoubleUp, Freeleech, and Sticky on upload api endpoint.
I've done limited testing on this and I'm worndering if this could be done better.