Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Enhancement) New options on torrent upload api #1247

Merged
merged 7 commits into from
Mar 22, 2020
Merged

(Enhancement) New options on torrent upload api #1247

merged 7 commits into from
Mar 22, 2020

Conversation

PyR8zdl
Copy link
Contributor

@PyR8zdl PyR8zdl commented Mar 18, 2020

Adds options to set torrent as Featured, DoubleUp, Freeleech, and Sticky on upload api endpoint.

I've done limited testing on this and I'm worndering if this could be done better.

Adds options to set torrent as Featured, DoubleUp, Freeleech, and Sticky on upload api endpoint.

I've done limited testing on this and I'm worndering if this could be done better.
@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #1247 into master will decrease coverage by 0.18%.
The diff coverage is 53.84%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1247      +/-   ##
============================================
- Coverage     26.89%   26.70%   -0.19%     
- Complexity     4157     4175      +18     
============================================
  Files           297      297              
  Lines         13129    13151      +22     
============================================
- Hits           3531     3512      -19     
- Misses         9598     9639      +41     
Impacted Files Coverage Δ Complexity Δ
app/Http/Controllers/API/TorrentController.php 68.00% <53.84%> (-3.43%) 102.00 <0.00> (+18.00) ⬇️
app/Services/Data/Tv.php 0.00% <0.00%> (-83.34%) 5.00% <0.00%> (ø%)
app/Services/MovieScrapper.php 55.55% <0.00%> (-27.78%) 10.00% <0.00%> (ø%)
...pp/Http/Controllers/Staff/MassActionController.php 68.75% <0.00%> (-6.25%) 6.00% <0.00%> (ø%)
app/Repositories/ChatRepository.php 67.66% <0.00%> (-3.60%) 47.00% <0.00%> (ø%)
app/Services/Clients/TmdbClient.php 4.60% <0.00%> (-2.31%) 89.00% <0.00%> (ø%)
app/Models/User.php 42.06% <0.00%> (-1.59%) 122.00% <0.00%> (ø%)
app/Http/Controllers/AnnounceController.php 45.88% <0.00%> (ø) 65.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 559b92f...102e283. Read the comment docs.

@PyR8zdl
Copy link
Contributor Author

PyR8zdl commented Mar 19, 2020

Ok, I think I got this mostly tested. I want to test a few more scenarios tomorrow.

@HDVinnie HDVinnie changed the title ADD new options on torrent upload **STILL TESTING** [WIP](Enhancement) New options on torrent upload api Mar 19, 2020
@PyR8zdl
Copy link
Contributor Author

PyR8zdl commented Mar 20, 2020

I've tested with all possible options and is working as intended. Hopefully, all the checks pass. 👍

@HDVinnie
Copy link
Collaborator

I've tested with all possible options and is working as intended. Hopefully, all the checks pass. 👍

It won't pass TravisCI until the test is updated. https://github.com/HDInnovations/UNIT3D-Community-Edition/blob/master/tests/Feature/Http/Controllers/API/TorrentControllerTest.php

If you cannot do it then I will this weekend before merging.

@HDVinnie
Copy link
Collaborator

@PyR8zdl I have simplified the if else to ternary and updated the test. Assuming it passes ill merge.

@HDVinnie HDVinnie changed the title [WIP](Enhancement) New options on torrent upload api (Enhancement) New options on torrent upload api Mar 22, 2020
@HDVinnie HDVinnie merged commit 57f88cd into HDInnovations:master Mar 22, 2020
@PyR8zdl
Copy link
Contributor Author

PyR8zdl commented Mar 22, 2020

@HDVinnie Nice, It looks alot better now. In future I will use this format. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants