Little language fix for PL #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by:VerioPL
HDVinnie
added a commit
that referenced
this pull request
Jul 26, 2018
- ${ converts to ${
And the bug occurs when the special replacement pattern $& (that
inserts the matched substring) is passed to the second argument of the
replace method (which is inside while loop) on this line:
bbdata = bbdata.replace(am[0],nhtml);
But when specifying a function as second parameter in replace method,
replacement patterns will not apply.
Roardom
added a commit
to Roardom/UNIT3D-Community-Edition
that referenced
this pull request
Jun 9, 2022
Initially, characters were only allowed when there was only one of them, so `[color=r]` would be accepted, but not `[color=red]`. This issue is now fixed. Additionally, short hex codes with transparency (e.g. `[color=HDInnovations#123]`) were also broken. This has now been fixed. Color values such as rgb(), rgba(), hsl() and hsla() are intentionally unsupported to prevent feature creep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verb -> noun for better experience