tests: Implement TorrentController API tests #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbj4074
force-pushed
the
torrent-controller-tests
branch
from
ae69249 to
471907b
Compare
HDVinnie
reviewed
Feb 24, 2020
cbj4074
force-pushed
the
torrent-controller-tests
branch
from
471907b to
d040a01
Compare
|
Rather than introduce a BC-break by moving the torrent file storage location, I'm going to preserve it and make the BC-breaking change in a 3.x major release branch. I'll push a commit that fixes that shortly. |
cbj4074
force-pushed
the
torrent-controller-tests
branch
from
d040a01 to
e904123
Compare
As part of this effort, a dedicated "torrents" storage location was added to filesystems.php, which affects the torrent file storage location. Accordingly, the torrent files in existing installations will need to be moved (or symlinked) upon upgrade. The primary reason for this change is mentioned in the Laravel docs: "This convention will keep your publicly accessible files in one directory that can be easily shared across deployments when using zero down-time deployment systems like Envoyer."
cbj4074
force-pushed
the
torrent-controller-tests
branch
from
e904123 to
aa32a89
Compare
HDVinnie
reviewed
Feb 24, 2020
HDVinnie
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this effort, a dedicated "torrents" storage location was
added to filesystems.php, which affects the torrent file storage
location. Accordingly, the torrent files in existing installations will
need to be moved (or symlinked) upon upgrade. The primary reason for
this change is mentioned in the Laravel docs: "This convention will
keep your publicly accessible files in one directory that can be easily
shared across deployments when using zero down-time deployment systems
like Envoyer."