tests: Delete conflicting DemoFactory #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This factory was causing unexpected behavior with the UserFactory; basically, this factory was taking precedence whenever factory(User::class) was called. Oddly, this factory was effective only in the Travis-CI environment and not anybody's respective local environment. Presumably, some nuance with the filesystem coupled with Composer's autoloader affects the order in which the respective factories are registered in different environments. In any case, this factory is no longer useful and is hereby deleted, which fixes a handful of test methods that heretofore had to be marked as incomplete.
|
@HDVinnie Indeed, removing that factory fixed everything in Travis. 👍 |
HDVinnie
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This factory was causing unexpected behavior with the UserFactory;
basically, this factory was taking precedence whenever
factory(User::class) was called.
Oddly, this factory was effective only in the Travis-CI environment and
not anybody's respective local environment. Presumably, some nuance
with the filesystem coupled with Composer's autoloader affects the
order in which the respective factories are registered in different
environments.
In any case, this factory is no longer useful and is hereby deleted,
which fixes a handful of test methods that heretofore had to be marked
as incomplete.