Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization in Staff/* views. #1137

Merged
merged 59 commits into from
Feb 13, 2020

Conversation

gyakkun
Copy link
Contributor

@gyakkun gyakkun commented Feb 13, 2020

I try hard to dig out the conflicts between my branch and upstream.

This branch should include no bug fix / enhancement / features but only with localization and translations. Please check seriously if any doubts arise.

Some adjustment may feels odd. Please comment.

MilkFather and others added 30 commits February 14, 2020 00:35
The translation of zh-cn has been further improved.
Now for zh-CN only, other languages to be done.
Now for zh-CN only, other languages to be done.
Now for zh-CN only, other languages to be done.
Now for zh-CN only, other languages to be done.
Now for zh-CN only, other languages to be done.
Now for zh-CN only, other languages to be done.
Now for zh-CN only, other languages to be done.
Now for zh-CN only, other languages to be done.
…w under Staff/.

Delete the original poll/forms/make.
Now for zh-CN only, other languages to be done.
Now for zh-CN only, other languages to be done.
Now for zh-CN only, other languages to be done.
Some lines are hard to localize like
"If Not Using A FontAwesome Icon"
without adding new lang items.
Feel free to cherry pick / revert.
It's hard for some languages' user to distinguish
verb or noun of word "type". This commit try to
deal with it. Feel free to cherry-pick / rebase
drop.
All appear in hinting emoji typing.

It's hard for some languages' user to distinguish
verb or noun of word "type". This commit try to
deal with it. Feel free to cherry-pick / rebase
drop.

With this commit and the previous one, the lang
item "common.type" now is used as noun and
feature the same semantic as plural lang item
 "common.types".
A/an is hard to localize. This commit try to deal
with it.
Copy link
Collaborator

@HDVinnie HDVinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gyakkun looks good to me. Few minor style changes I committed directly. Appreciate the contributions very much!

@HDVinnie
Copy link
Collaborator

@all-contributors please add @gyakkun for translation

@allcontributors
Copy link
Contributor

@HDVinnie

I've put up a pull request to add @gyakkun! 🎉

@HDVinnie
Copy link
Collaborator

@gyakkun Do you plan to do more in this Pull Request? Im going to test it locally in a few.

@gyakkun
Copy link
Contributor Author

gyakkun commented Feb 13, 2020

@gyakkun Do you plan to do more in this Pull Request? Im going to test it locally in a few.

There's one last page(Staff/warning). Let me finish it.

@gyakkun
Copy link
Contributor Author

gyakkun commented Feb 13, 2020

I think that's all for this PR. Thank you for reviewing!

@HDVinnie HDVinnie merged commit 7f93117 into HDInnovations:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants