Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to link definitions to certain words #28

Closed
H4ppy-04 opened this issue May 27, 2023 · 0 comments · Fixed by #29
Closed

Failure to link definitions to certain words #28

H4ppy-04 opened this issue May 27, 2023 · 0 comments · Fixed by #29
Labels
bug Something isn't working

Comments

@H4ppy-04
Copy link
Owner

Description

In the current implementation, definitions and their corresponding explanations/examples occasionally fail to link to the appropriate words. This issue arises when there are duplicate words or when certain words are not flagged by the lxml library.

Reproduction Steps

  1. Index a definition and observe words that aren't colored that should be colored in the definition and or example.
  2. Take note of the duplicate words or non flagged words associated with the unlinked definitions.

Expected Behavior

Definitions should consistently link to the appropriate words, providing users with a streamlined experience when looking up definitions.

Actual Behavior

Definitions and their explanations/examples occasionally fail to link to the intended words due to the presence of duplicate words or non flagged words that lxml does not recognize.

Possible Solution

The issue is currently under investigation. Once the root cause is identified, the appropriate fix will be implemented to ensure accurate linking of definitions to words. This could involve refining the linking algorithm to handle duplicate words or improving the word flagging mechanism within lxml.

Impact

This issue affects the overall usability and functionality of the application, as it hinders users' ability to quickly access relevant definitions and their corresponding explanations/examples. By addressing this issue, we aim to enhance the user experience and provide a more reliable resource.

Related Issues

This issue will be updated with further information as progress is made towards resolving it.

@H4ppy-04 H4ppy-04 added the bug Something isn't working label May 27, 2023
@H4ppy-04 H4ppy-04 linked a pull request May 27, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant