Fixing caps lock input on macOS #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Querying for the current state of caps lock after coming back to foreground is not implemented
dpogue
approved these changes
Jul 7, 2024
| @@ -171,8 +177,11 @@ - (BOOL)processKeyEvent:(NSEvent*)event | |||
| } | |||
|
|
|||
| @synchronized(self.view.layer) { | |||
| self.inputManager->HandleKeyEvent( | |||
| (plKeyDef)keycode, down, event.type == NSEventTypeFlagsChanged ? false : event.ARepeat); | |||
| // Caps lock modifer has sepcial handling that was earlier | |||
Attempting to correct caps lock state if it’s changed in the background
colincornaby
force-pushed
the
mac-caps-lock
branch
from
861ecdc to
95a5e9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for fixing #1599.
I don't see any facilities in Cocoa to query the current state of caps lock, only updates. It seems like that might be present in HID - but HID is gated by security permissions in recent macOS releases. So far I've considered HID out of bounds for macOS.
@dpogue - If you have any Cocoa APIs I don't know about I'd be happy to implement. Would also be happy to forward on to Apple for guidance. I didn't see anything during my research online - and it does not even seem like the Game Controller framework supports querying Caps Lock. But my investigation was pretty shallow.