Merge pull request #1601 from colincornaby/mac-caps-lock

Fixing caps lock input on macOS
H-uru · Jul 7, 2024 · 01d0704 · 01d0704
2 parents 04c72ac + 95a5e9a
commit 01d0704
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/Sources/Plasma/Apps/plClient/Mac-Cocoa/PLSKeyboardEventMonitor.mm b/Sources/Plasma/Apps/plClient/Mac-Cocoa/PLSKeyboardEventMonitor.mm
@@ -66,6 +66,7 @@ @interface PLSKeyboardEventMonitor ()
 @property(weak) NSView* view;
 @property plInputManager* inputManager;
 @property(retain) id localMonitor;
+@property BOOL capsLockKeyDown;
 
 @end
 
@@ -152,7 +153,12 @@ - (BOOL)processKeyEvent:(NSEvent*)event
     if (keycode == kVK_Control) {
         down = (event.modifierFlags & NSEventModifierFlagControl) != 0;
     }
-
+    BOOL capsLockMaskPresent = (event.modifierFlags & NSEventModifierFlagCapsLock) != 0;
+    if (capsLockMaskPresent != self.capsLockKeyDown) {
+        self.capsLockKeyDown = capsLockMaskPresent;
+        self.inputManager->HandleKeyEvent((plKeyDef)kVK_CapsLock, self.capsLockKeyDown, false);
+    }
+
     /*
      This gets weird.
      Recent Apple hardware is starting to have its system key shortcuts assigned to the fn key
@@ -171,8 +177,11 @@ - (BOOL)processKeyEvent:(NSEvent*)event
     }
 
     @synchronized(self.view.layer) {
-        self.inputManager->HandleKeyEvent(
-            (plKeyDef)keycode, down, event.type == NSEventTypeFlagsChanged ? false : event.ARepeat);
+        // Caps lock modifer has special handling that was earlier
+        if (keycode != kVK_CapsLock) {
+            self.inputManager->HandleKeyEvent(
+                                              (plKeyDef)keycode, down, event.type == NSEventTypeFlagsChanged ? false : event.ARepeat);
+        }
         if (!(modifierFlags & NSEventModifierFlagFunction) && down) {
             if (event.type != NSEventTypeFlagsChanged && event.characters.length > 0) {
                 // Only works for BMP code points (up to U+FFFF), but that's unlikely to matter at

diff --git a/Sources/Plasma/PubUtilLib/plInputCore/plInputDevice.cpp b/Sources/Plasma/PubUtilLib/plInputCore/plInputDevice.cpp
@@ -186,6 +186,8 @@ void plKeyboardDevice::HandleKeyEvent(plKeyDef key, bool bKeyDown, bool bKeyRepe
         {
 #ifdef HS_BUILD_FOR_WIN32
             fCapsLockLock = (GetKeyState(KEY_CAPSLOCK) & 1) == 1;
+#else
+            fCapsLockLock = bKeyDown;
 #endif
             plAvatarInputInterface::GetInstance()->ForceAlwaysRun(fCapsLockLock);
         }