Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winget shared build installation is broken #154

Closed
pyorot opened this issue Oct 8, 2024 · 8 comments
Closed

Winget shared build installation is broken #154

pyorot opened this issue Oct 8, 2024 · 8 comments

Comments

@pyorot
Copy link

pyorot commented Oct 8, 2024

See explanation:

When installed via installer, symlinks for the exe files are created in "%LocalAppData%\Microsoft\WinGet\Links", and this directory is then added to the current user path variable (not the machine path). The issue is that the exe, when run, will be the symlink. The exe tries to locate the shared dll files from its launch directory and if not found then via searching the path. The launch directory will be "%LocalAppData%\Microsoft\WinGet\Links" and the dlls are not referenced there. Windows does not automatically search the target directory of a symlink, so the dlls are never found because they can't be found via the combined local user + machine path string.

Just encountered this problem myself and wonder what can be done about it…

@GyanD
Copy link
Owner

GyanD commented Oct 9, 2024

This needs to be addressed by Winget. My package contents just form a passive payload. There's no installer or script included.

See microsoft/winget-pkgs#103471 and microsoft/winget-cli#2711

@pyorot
Copy link
Author

pyorot commented Oct 17, 2024

Oh that's cringe; I had no idea. I can at least update that reddit thread with this info tho. Would it make sense then to stop releasing a shared build on winget since it just doesn't work out of the box?

@GyanD
Copy link
Owner

GyanD commented Oct 18, 2024

The issue has been fixed in Winget. See comments starting at microsoft/winget-cli#2711 (comment)

@pyorot
Copy link
Author

pyorot commented Oct 18, 2024

Good timing :O. Have you submitted an updated manifest?

@GyanD
Copy link
Owner

GyanD commented Oct 18, 2024

That's upto the package maintainer @SpecterShell

@SpecterShell
Copy link

That patch will be applied to the package validation pipeline after WinGet client 1.9 stable is generally available, after which I'll update the manifests ;).

@pyorot
Copy link
Author

pyorot commented Nov 2, 2024

That patch will be applied to the package validation pipeline after WinGet client 1.9 stable is generally available, after which I'll update the manifests ;).

@SpecterShell just in case you forgot now that 1.9 is out, since i see the pull request for this is closed

@SpecterShell
Copy link

That patch will be applied to the package validation pipeline after WinGet client 1.9 stable is generally available, after which I'll update the manifests ;).

@SpecterShell just in case you forgot now that 1.9 is out, since i see the pull request for this is closed

I'm waiting for microsoft/winget-pkgs#186398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants