Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine Reducer #38

Open
gpltaylor opened this issue Jul 6, 2016 · 3 comments
Open

Combine Reducer #38

gpltaylor opened this issue Jul 6, 2016 · 3 comments

Comments

@gpltaylor
Copy link

Is there an ability to support combined Reducers? I have looked over the code and can't see this.

It would be a great feature!

@lilasquared
Copy link

@gpltaylor lots of the stuff from redux that is cool is allowed because it is javascript which doesn't have type safety. I think that @GuillaumeSalles was trying to create something that follows redux patterns as well as conforming to type safety of C#. (we discussed a similar issue with middleware here) I can't think of a way to implement combine reducers without using a dictionary type definition for the state but then the type safety is gone and you might as well be writing javascript =]

@lilasquared
Copy link

@gpltaylor I thought about this for a long time and finally came up with something that does the trick. check out my implementation https://github.com/lilasquared/NRedux. I would like to see if I can work it into Redux.Net as well @GuillaumeSalles if you like mine I can try and come up with a PR for you.

@lilasquared
Copy link

@gpltaylor if you're still interested in this we had a discussion about it here #51. It turns out if you design the state object and reducers in a better way than i was doing you don't need a combine reducers method. Let me know if that works for you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants