New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: formatting #3

Open

Guekka opened this issue Jun 22, 2023 · 1 comment

Owner

Guekka commented Jun 22, 2023

Currently, the CI checks for invalid formatting and autocommits fixes. This has several issues:

breaks with branch protection rules
creates useless commits

Instead, it would be better to reject PRs with invalid formatting, letting the author fix it. We could also add pre-commit hooks

Owner Author

Guekka commented Jul 16, 2023

For now, we simply disabled formatting on main branch, since it is protected anyway e409932
May reopen if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment