Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

question about array index limit #297

Closed
ihsinme opened this issue Nov 28, 2022 · 2 comments · Fixed by #319
Closed

question about array index limit #297

ihsinme opened this issue Nov 28, 2022 · 2 comments · Fixed by #319
Assignees
@TimvdBroecke
Labels
bug Potential bug in ProGuard. confirmed

Comments

@ihsinme
Copy link

ihsinme commented Nov 28, 2022

sorry if my question is stupid.
shouldn't the index limit be strictly less than the size.

proguard/base/src/main/java/proguard/fixer/kotlin/KotlinAnnotationCounter.java

Line 75 in 84ac82e

parameterAnnotationCount.length > 0 && index <= parameterAnnotationCount.length

@JagoGyselinck JagoGyselinck added bug Potential bug in ProGuard. confirmed labels Dec 14, 2022
@JagoGyselinck
Copy link
Contributor

Hello @ihsinme

It's definitely not a stupid question, this is indeed a bug in the code :-)
Assigning to @TimvdBroecke

@tvoc-gs
Copy link
Contributor

tvoc-gs commented Feb 28, 2023

Hello @ihsinme,

This has been fixed with 745a681 and will be included with the next release.

@mrjameshamilton mrjameshamilton linked a pull request Mar 1, 2023 that will close this issue
Fix off-by-one error #319
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimvdBroecke TimvdBroecke

Labels
bug Potential bug in ProGuard. confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix off-by-one error Guardsquare/proguard
5 participants
@TimvdBroecke @mrjameshamilton @JagoGyselinck @ihsinme @tvoc-gs