Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options --select-tab, --split-vertical (--split-horizontal) and -execute-command not working as before (v. 3.8.4). #2167

Closed
carlosromel opened this issue Mar 14, 2023 · 1 comment · Fixed by #2172

Comments

@carlosromel
Copy link

carlosromel commented Mar 14, 2023

Instaled from ppa

sudo add-apt-repository ppa:linuxuprising/guake
sudo apt-get update
sudo apt install guake

Describe the bug
When using --select-tab, --split-vertical (or --split-horizontal) and --execute-command, guake selects correct tab, split screen but not execute desired command on new area. Instead, execute command on new tab.

Expected behavior
This behavior worked on previous versions (before remove of execute-command and later reinclusion of this option).

Actual behavior
guake selects desired tab, split tab content but run command on new tab.

What you actually get.
Tab open, splited and not command running on it. Other tab with desired command running.

To Reproduce

#!/bin/bash

TAB=$(guake --selected-tab)
echo "Tab #: ${TAB}"
guake                                        --execute-command='guake --selected-tab; echo top -s'

TAB=$(( TAB + 1 ))
echo "Tab #: ${TAB}"
guake --rename-tab="Legacy & instances"      --execute-command='guake --rename-tab="Legacy System";   echo "Legacy system"'

TAB=$(( TAB + 1 ))
echo "Tab #: ${TAB}"
guake --select-tab=${TAB} --split-vertical   --execute-command='guake --rename-tab="First instance";  echo "First instance"'
guake --select-tab=${TAB} --split-horizontal --execute-command='guake --rename-tab="Second instance"; echo "Second instance"'

Screenshots
shot-2023-03-14_12-43-22
shot-2023-03-14_12-43-27
shot-2023-03-14_12-43-32
shot-2023-03-14_12-43-36
shot-2023-03-14_12-43-42


$ guake --support

Guake Version: 3.9.0

Vte Version: 0.68.0

Vte Runtime Version: 0.68.0


GTK+ Version: 3.24.33

GDK Backend: <GdkX11.X11Display


Desktop Session: enlightenment


Display: :0.0

RGBA visual: True

Composited: True

  • Monitor: 0 - GSM VGA-1
    • Geometry: 1600 x 900 at 0, 0
    • Size: 443 x 249 mm²
    • Primary: True
    • Refresh rate: 60.0 Hz
    • Subpixel layout: unknown
  • Monitor: 1 - GSM HDMI-2
    • Geometry: 1920 x 1080 at 1600, 0
    • Size: 510 x 290 mm²
    • Primary: False
    • Refresh rate: 60.0 Hz
    • Subpixel layout: unknown
  • Monitor: 2 - OEM HDMI-3
    • Geometry: 1600 x 900 at 3520, 0
    • Size: 432 x 238 mm²
    • Primary: False
    • Refresh rate: 60.0 Hz
    • Subpixel layout: unknown
@carlosromel carlosromel changed the title Options --select-tab, --split-vertical or --split-horizontal and -execute-command not working together. .Options --select-tab, --split-vertical (--split-horizontal) and -execute-command not working as before (v. 3.8.4). Mar 14, 2023
@carlosromel carlosromel changed the title .Options --select-tab, --split-vertical (--split-horizontal) and -execute-command not working as before (v. 3.8.4). Options --select-tab, --split-vertical (--split-horizontal) and -execute-command not working as before (v. 3.8.4). Mar 14, 2023
@Davidy22
Copy link
Collaborator

Davidy22 commented May 9, 2023

--execute-command was removed in a previous version because it enabled a security flaw, which could be avoided by only allowing the flag to run on new tabs, so it was brought back with altered behavior in a later version. Although I guess this specific scenario where the flag is combined with split- should be fine to allow not making a new tab since it's still spawning a new terminal in the split screen.

Can't allow for selecting an existing terminal after the split to run the command in an already running terminal though, as that would reintroduce the security flaw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants