modify build process to generate javadoc and one bundled jar + fix checkstyle (#307)

Author: vmarchaud

build.gradle

@@ -8,8 +8,6 @@ buildscript {
     dependencies {
         classpath 'com.google.protobuf:protobuf-gradle-plugin:0.7.7'
     }
-
-
 }
 
 apply plugin: 'idea'
@@ -45,8 +43,6 @@ processResources {
 
 // Run this task to bundle all needed dependency
 task bundle(type: Jar) {
-    baseName = project.name + '_bundle'
-
     from {
         configurations.compile.collect {
             it.isDirectory() && !it.isEmpty() ? it : zipTree(it)
@@ -55,6 +51,8 @@ task bundle(type: Jar) {
     with jar
 }
 
+build.finalizedBy(bundle)
+
 protobuf {
     // Configure the protoc executable
     protoc {
@@ -114,11 +112,19 @@ idea {
     }
 }
 
-task sourcesJar(type: Jar) {
-    from sourceSets.main.java.srcDirs
+task sourcesJar(type: Jar, dependsOn: classes) {
     classifier = 'sources'
+    from sourceSets.main.allJava
+}
+
+task javadocJar(type: Jar, dependsOn: javadoc) {
+    classifier = 'javadoc'
+    javadoc.failOnError(false);
+    javadoc.source = sourceSets.main.allJava
+    from javadoc.destinationDir
 }
 
 artifacts {
     archives sourcesJar
+    archives javadocJar
 }

src/main/java/com/pokegoapi/auth/GoogleAutoCredentialProvider.java

@@ -46,12 +46,12 @@ public GoogleAutoCredentialProvider(OkHttpClient httpClient, String username, St
 	}
 
 	/**
-	 * Constructs credential provider using username and password
-	 *
-	 * @param username - google username
-	 * @param password - google password
-	 * @param Time - time object
-	 * @throws LoginFailedException  - login failed possibly due to invalid credentials
+	 * 
+	 * @param httpClient : the client that will make http call
+	 * @param username : google username
+	 * @param password : google pwd
+	 * @param time : time instance used to refresh token
+	 * @throws LoginFailedException -  login failed possibly due to invalid credentials
 	 * @throws RemoteServerException - some server/network failure
 	 */
 	public GoogleAutoCredentialProvider(OkHttpClient httpClient, String username, String password, Time time)

src/main/java/com/pokegoapi/auth/GoogleCredentialProvider.java

@@ -57,7 +57,6 @@ public class GoogleCredentialProvider extends CredentialProvider {
 
 	/**
 	 * Used for logging in when one has a persisted refreshToken.
-	 * Deprecated: specify a Time implementation
 	 *
 	 * @param client       OkHttp client
 	 * @param refreshToken Refresh Token Persisted by user