New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split utilsac into separate projects #4

Closed

5 tasks done

GrosSacASac opened this issue Apr 17, 2019 · 5 comments

Assignees

Labels

meta

Owner

GrosSacASac commented Apr 17, 2019 •

edited

Loading

Owner Author

GrosSacASac commented Apr 20, 2019

https://github.com/GrosSacASac/filesac

Owner Author

GrosSacASac commented Apr 20, 2019

https://github.com/GrosSacASac/randomsac

Owner Author

GrosSacASac commented Apr 20, 2019

https://github.com/GrosSacASac/operatorsac

GrosSacASac closed this as completed in

77690fd

GrosSacASac reopened this

GrosSacASac self-assigned this

Owner Author

GrosSacASac commented Oct 3, 2019

deep.js into deep-sac
evalGlobal into eval-sac
remove blob (put link in the changelog)
typecast into type-sac

GrosSacASac changed the title ~~Split into 5 separate project~~ Split utilsac into separate projects

GrosSacASac added the meta label

Owner Author

GrosSacASac commented Feb 19, 2020

closing for now, here's my thoughts
Pro

Single responsibility principle
Clean

Not true anymore

Dead code : Any modern application uses treeshaking

Contra

Easier to manage monorepo
Would have to update depending projects eventually

GrosSacASac closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment