style[eve]: remove unused imports and fix typos #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanc
commented
Nov 26, 2024
Comment on lines
-92
to
-100
| "# datamodels" "Coerced", | ||
| "DataModel", | ||
| "FrozenModel", | ||
| "GenericDataModel", | ||
| "Unchecked", | ||
| "concretize", | ||
| "datamodel", | ||
| "field", | ||
| "frozenmodel", |
There was a problem hiding this comment.
These are duplicated in the lines to follow.
romanc
force-pushed
the
romanc/cleanup-eve
branch
from
3161005
to
fbd4461
Compare
egparedes
reviewed
Nov 26, 2024
Remove extra quote Co-authored-by: Enrique González Paredes <[email protected]>
Thanks for the inline comment: missed that 👍 What was your question? |
|
@twicki @FlorianDeconinck FYI: the great cleanup continues ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small cleanup PR in the eve framework:
.gitignorefile. As far as I understood from the git history, earlier versions of this codebase had many.gitignorefiles in many places. Looks like this one is a leftover from a previous time.Requirements
N/A: neither fixes nor new features
N/A