bug[next]: Fix codegen in gtfn for unused vertical offset provider #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's add a test, it's not obvious to me how to trigger that bug. |
havogt
reviewed
Nov 25, 2024
| @@ -229,6 +229,7 @@ def simple_mesh() -> MeshDescriptor: | |||
| C2E.value: gtx.NeighborTableOffsetProvider( | |||
| c2e_arr, Cell, Edge, 4, has_skip_values=False | |||
| ), | |||
| Koff.value: KDim, | |||
There was a problem hiding this comment.
Why is this change here? I don't understand how this is related. Is it required to make the test below fail before the fix?
There was a problem hiding this comment.
This is an easy way to trigger the error.
There was a problem hiding this comment.
But not the best I guess. An isolated test would be one that has an Cartesian offset for a dimension that is not in any field?
There was a problem hiding this comment.
any updates on this? I would need it for C2SM/icon4py#564
tehrengruber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing an offest provider for a vertical dimension without using that dimension in a program, e.g. no arguments are fields defined on K, resulting in erroneous C++ code.