Refactor tree_map and replace apply_to_primitive_constituents #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Till Ehrengruber <[email protected]>
Co-authored-by: Till Ehrengruber <[email protected]>
… and run pre-commit (still failing because of src/gt4py/next/type_system/type_info.py:186:17: error: No overload variant of "tree_map" matches argument types "type[TupleType]", "Callable[[Any], TupleType]" [call-overload] )
tehrengruber
reviewed
Aug 6, 2024
| def tree_map( | ||
| *args: Callable[_P, _R], | ||
| collection_type: type | tuple[type, ...] = tuple, | ||
| result_collection_constructor: Optional[type] = None, # Todo: check name with Enrique |
There was a problem hiding this comment.
Suggested change
| result_collection_constructor: Optional[type] = None, # Todo: check name with Enrique | |
| result_collection_constructor: Optional[type] = None, |
Name is been approved by Hannes.
tehrengruber
added a commit
that referenced
this pull request
Sep 17, 2024
Extends the common subexpression elimination to support the new itir.Program node and pushes the intermediate Fencil -> Program conversion upwards the pass manager. The CSE pass now uses the type inference such that only field expressions or composites thereof are collected in field-view context (i.e. outside of as_fieldop). This PR was initially meant to be merged into the temporary GTIR branch and reviewed by @egparedes here: #1570. The only change since then is to make dace tests pass (see commit 160a616). --------- Co-authored-by: edopao <[email protected]> Co-authored-by: Enrique González Paredes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor tree_map and replace apply_to_primitive_constituents (building upon PR#1530)
Description
result_collection_typetoresult_collection_constructorTODOs
with_path_arg=True