bug[next]: Use same python in CMake as used for execution #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havogt
reviewed
Jul 3, 2024
| @@ -76,7 +76,7 @@ | |||
| BOOL_TYPES: Final[Tuple[type, ...]] = cast(Tuple[type, ...], BoolScalar.__args__) # type: ignore[attr-defined] | |||
|
|
|||
|
|
|||
| IntScalar: TypeAlias = Union[int8, int16, int32, int64, int] | |||
There was a problem hiding this comment.
is this intentional in this PR? If yes, that's not the right solution.
egparedes
reviewed
Jul 4, 2024
| python_executable = sys.executable | ||
|
|
||
| # Get Python library path | ||
| python_library = sysconfig.get_config_var('LIBDIR') + '/' + sysconfig.get_config_var('LDLIBRARY') |
There was a problem hiding this comment.
Just a suggestion:
Suggested change
| python_library = sysconfig.get_config_var('LIBDIR') + '/' + sysconfig.get_config_var('LDLIBRARY') | |
| python_library = f"{sysconfig.get_config_var('LIBDIR')}/{sysconfig.get_config_var('LDLIBRARY')}" |
Fix operations on Field with origin different form zero (Identified on GridTools.jl)
|
@tehrengruber What is the status of this PR? If it is still relevant and needed you should address the issues from the review. And how is the last commit related to the other contents of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.