ender fluid cover #2505
Open
ender fluid cover #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/com/gregtechceu/gtceu/common/data/GTItems.java
screret
requested changes
Dec 6, 2024
src/main/java/com/gregtechceu/gtceu/common/cover/ender/CoverAbstractEnderLink.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/misc/virtualregistry/VirtualEnderRegistry.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/common/cover/ender/CoverAbstractEnderLink.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/common/cover/ender/EnderFluidLinkCover.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/misc/virtualregistry/EntryTypes.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/misc/virtualregistry/VirtualEntry.java
Outdated
Show resolved
Hide resolved
Comment on lines
+142
to
+188
| // damn I can't make the list panel work in the server side | ||
| // private SelectableWidgetGroup createVisualTankWidget(VisualTank tank, int y) { | ||
| // final int TOTAL_WIDTH = 116; | ||
| // final int BUTTON_SIZE = 20; | ||
| // final int MARGIN = 2; | ||
| // | ||
| // int currentX = 0; | ||
| // int availableWidth = TOTAL_WIDTH - BUTTON_SIZE + MARGIN; | ||
| // | ||
| // SelectableWidgetGroup channelGroup = new SelectableWidgetGroup(0, y, TOTAL_WIDTH, BUTTON_SIZE){ | ||
| // @Override | ||
| // public void drawInForeground(@NotNull GuiGraphics graphics, int mouseX, int mouseY, float partialTicks) { | ||
| // super.drawInForeground(graphics, mouseX, mouseY, partialTicks); | ||
| // if (super.isSelected) | ||
| // DrawerHelper.drawBorder(graphics, getPositionX(), getPositionY(), TOTAL_WIDTH, BUTTON_SIZE, 0xFFFFFFFF, 1); | ||
| // } | ||
| // }; | ||
| // var name = tank.getVirtualTank().getColorStr(); | ||
| // | ||
| // // Color block | ||
| // channelGroup.addWidget(new ColorBlockWidget(currentX, 0, BUTTON_SIZE, BUTTON_SIZE) | ||
| // .setCurrentColor(tank.getVirtualTank().getColor())); | ||
| // currentX += BUTTON_SIZE + MARGIN; | ||
| // | ||
| // // Text box | ||
| // int textBoxWidth = availableWidth; | ||
| // textBoxWidth -= BUTTON_SIZE + MARGIN; | ||
| // if (tank.getFluidAmount() == 0) { | ||
| // textBoxWidth -= BUTTON_SIZE + MARGIN; | ||
| // } | ||
| // channelGroup.addWidget( | ||
| // new TextBoxWidget(currentX, 6, textBoxWidth, List.of(name)).setCenter(true)); | ||
| // currentX += textBoxWidth + MARGIN; | ||
| // | ||
| // // Tank slot | ||
| // channelGroup.addWidget(new TankWidget(tank, currentX, 0, | ||
| // BUTTON_SIZE, BUTTON_SIZE, false, false) | ||
| // .setBackground(GuiTextures.FLUID_SLOT)); | ||
| // currentX += BUTTON_SIZE + MARGIN; | ||
| // | ||
| // // Remove button (if tank is empty) | ||
| // if (tank.getFluidAmount() == 0) { | ||
| // channelGroup.addWidget(new ButtonWidget(currentX, 0, BUTTON_SIZE, BUTTON_SIZE, | ||
| // GuiTextures.BUTTON_INT_CIRCUIT_MINUS, cd -> removeChannel(tank))); | ||
| // } | ||
| // return channelGroup; | ||
| // } |
There was a problem hiding this comment.
we'll figure out a solution here
screret
approved these changes
Dec 12, 2024
|
conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds ender cover system.
Implementation Details
The implementation includes new classes for virtual cover.
Outcome
Players can now create customized virtual tanks for fluid management, enhancing the gameplay experience.
Additional Information
show channel list is not finished, I can't make it work in server...