javascript queries: fix parameters (helix-editor#3280)

GreasySlug · Aug 2, 2022 · 5494204 · 5494204
1 parent 6952f96
commit 5494204
Show file tree

Hide file tree

Showing 3 changed files with 44 additions and 13 deletions.
diff --git a/runtime/queries/javascript/highlights-params.scm b/runtime/queries/javascript/highlights-params.scm
diff --git a/runtime/queries/javascript/highlights.scm b/runtime/queries/javascript/highlights.scm
@@ -46,6 +46,43 @@
 (assignment_expression
   left: (identifier) @function
   right: [(function) (arrow_function)])
+
+; Function and method parameters
+;-------------------------------
+
+; (p) => ...
+(formal_parameters 
+  (identifier) @variable.parameter)
+
+; (...p) => ...
+(formal_parameters
+  (rest_pattern
+    (identifier) @variable.parameter))
+
+; ({ p }) => ...
+(formal_parameters
+  (object_pattern
+    (shorthand_property_identifier_pattern) @variable.parameter))
+
+; ({ a: p }) => ...
+(formal_parameters
+  (object_pattern
+    (pair_pattern
+      value: (identifier) @variable.parameter)))
+
+; ([ p ]) => ...
+(formal_parameters
+  (array_pattern
+    (identifier) @variable.parameter))
+
+; (p = 1) => ...
+(formal_parameters
+  (assignment_pattern
+    left: (identifier) @variable.parameter))
+
+; p => ...
+(arrow_function
+  parameter: (identifier) @variable.parameter)
 
 ; Function and method calls
 ;--------------------------

diff --git a/runtime/queries/javascript/locals.scm b/runtime/queries/javascript/locals.scm
@@ -12,7 +12,13 @@
 ; Definitions
 ;------------
 
-(pattern/identifier)@local.definition
+(pattern/identifier) @local.definition
+
+(pattern/rest_pattern 
+  (identifier) @local.definition)
+
+(arrow_function
+  parameter: (identifier) @local.definition)
 
 (variable_declarator
   name: (identifier) @local.definition)