closeTab calls finish() instead of finishAndRemoveTask()

ikicha · thestinger · commit b0ab84083d70 · 2025-03-25T12:40:00.000-04:00
It doesn't need to be finishAndRemoveTask() and it causes weird behavior
in resize scenario, because finishAndRemoveTask() cleans up Resize
Activity before it's ready to restart MainActivity, so it shows Launcher
for a while which is very weird.

Bug: 405412371
Test: resize
Change-Id: I62c5475b161217c0e88841d538c3a16def502d28
diff --git a/android/TerminalApp/java/com/android/virtualization/terminal/MainActivity.kt b/android/TerminalApp/java/com/android/virtualization/terminal/MainActivity.kt
@@ -194,7 +194,7 @@ public class MainActivity :
 
     fun closeTab(tab: TabLayout.Tab) {
         if (terminalTabAdapter.tabs.size == 1) {
-            finishAndRemoveTask()
+            finish()
         }
         viewPager.offscreenPageLimit -= 1
         terminalTabAdapter.deleteTab(tab.position)

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@ public class MainActivity :`
`194`	`194`
`195`	`195`	`fun closeTab(tab: TabLayout.Tab) {`
`196`	`196`	`if (terminalTabAdapter.tabs.size == 1) {`
`197`		`- finishAndRemoveTask()`
	`197`	`+ finish()`
`198`	`198`	`}`
`199`	`199`	`viewPager.offscreenPageLimit -= 1`
`200`	`200`	`terminalTabAdapter.deleteTab(tab.position)`