-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Previews are not visible #460
Comments
Which version of the camera app are you using? |
The last one, the 73 |
Hi @Jennifer2005x, Thanks a lot for reporting this issue and sorry for the inconvenience you're facing. Did this issue exist on your device in v72? |
Since I downloaded the app (approximately a few months) I have had that problem, until now I found out that they have github |
Ah that seems unusual. Could you please share the logcat while trying to access the in-app gallery? If any internal/app level component logs this issue, we could dive in deeper to see what went wrong Also, by any little chance, does the image show up when the device is rotated in horizontal orientation? |
And no, the image does not appear when changing the orientation |
Hi @Jennifer2005x, I don't think there's anything relevant in the logs unfortunately. Not being able to reproduce this behavior makes it harder to know what could have gone wrong there, I think we'll need to share a debug build with some more log messages to debug this further. I'll share a debug apk here soon. Also, are you able to see the details of the photo while clicking on the info icon in the top navigation bar? We could know if it's a rendering problem an issue with loading the saved image uris that way to further narrow down to the exact issue |
|
The issue seems to be with the rendering in that case. Could be related to the bitmap (image) being too large for the device to render due to memory constraints or other reasons |
Could you please try out the debug apk in the below link for this issue? |
Still the same |
Hi @Jennifer2005x, Sorry to keep you waiting. I have maximized our existing image downscaling logic to a high extent to confirm that this is a rendering/memory related issue in the debug apk uploaded in the link below: https://drive.proton.me/urls/4V5PXPA2R8#OEzrJI1XgZz7 Could you please try this debug apk to check if you're able to view a low-quality image of a recently taken photo? We could look for better image down scaling algorithm or constant to see if that could resolve the issue |
It works, but it looks blurry |
Yes that's the expected behavior, we just downscaled the image to a great extent to confirm that the issue lies there. I'll share an apk file for testing, once we have a fix ready for the same. Thanks a lot for your time and help! |
Hi @Jennifer2005x, Could you please share the device model you're using for the camera app? |
Also, could you please try this test apk on your device? https://drive.proton.me/urls/3YKPK5YC04#YJ4JHLjq2ydu |
It's a Samsung A022M |
Same |
Hi @Jennifer2005x, Could you please test the following debug apk on your device to check if it the preview is visible in the latest changes? |
Glad to know that it's working as expected. Will make a PR to include this fix soon after a issue with the new implementation gets addressed and after some testing. Thanks for confirming @Jennifer2005x! |
Hi @Jennifer2005x, Could you please test the in-app gallery of the app present in the following apk? |
I have a phone with Android 10 and I love this camera and how private it is, I only have this problem, the previews are seen from the small button but when I want to see them it does not appear, I hope they fix it, it is a good camera
The text was updated successfully, but these errors were encountered: