Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updatesrc on image change #541

Closed
kickbk opened this issue Nov 17, 2017 · 4 comments
Closed

updatesrc on image change #541

kickbk opened this issue Nov 17, 2017 · 4 comments
Labels

Comments

@kickbk
Copy link

kickbk commented Nov 17, 2017

I must be missing something, but when I change an image, the localstorage html isn't updating, however, changing the text does. So when I refresh the page after changing an image and text, the text remains, but the image not. Is there a setting I need to change to make the localstorage html update the image src?

@artf
Copy link
Member

artf commented Nov 20, 2017

Thanks for the catch @kickbk, actually src was not listened. The fix will be available in the next release

@artf artf closed this as completed in c92dd3b Nov 22, 2017
@xamdam777
Copy link

Hi @artf
This is not working in the current demo (neither on my side). If you change any image and reload the page, the image goes to it's previous src.

It's not working the first time you load a template. If you add new images in the current canvas, the src listener works as expected.

I have been debugging it for some hours, but all the ideas were unsuccessful :(

@xamdam777
Copy link

xamdam777 commented Apr 30, 2018

I had to solve this using a workaround and it seems like a good solution at the moment.
I have created my own localstorage and I'm saving the template on $(window).on('unload...
and loading it again on $(window).on('load'

@lock
Copy link

lock bot commented Sep 17, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label Sep 17, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants