Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Products API 5? #19

Open
mikeover opened this issue Jan 23, 2020 · 6 comments
Open

Updates for Products API 5? #19

mikeover opened this issue Jan 23, 2020 · 6 comments

Comments

@mikeover
Copy link
Contributor

I don't think this library will work anymore with Amazon Product Advertising API 5.0 and will be useless after the old version is discontinued on 3/9/2020. Any plans to update this library to work with 5.0?

@keslert
Copy link
Contributor

keslert commented Feb 28, 2020

Also interested in this as the deadline to switch to API 5.0 is March 9.

@Grantimus9
Copy link
Owner

I've spent a few hours on updating this, and have some work in progress.

Amazon moving from PA4 to PA5 also means they are using an auth/signing system that's giving me some grief. On the plus side, most requests now amount to POSTing some JSON to their endpoints and their endpoints now return JSON instead of XML.

I'm cautiously optimistic that this won't be as terrible of a migration for our package users as initially expected.

@keslert
Copy link
Contributor

keslert commented Mar 29, 2020

I made a little progress on an update as well. I didn't cover all the options, but maybe this will help? https://github.com/keslert/elixir-amazon-product-advertising-client

@Grantimus9
Copy link
Owner

Grantimus9 commented Mar 29, 2020

Does your signature generation code work? I'm using the AWSAuth lib and getting pretty close (branch open on this repo with the basics).

edit: if the signing code in your fork works, I'm all for adopting that, including the way you've setup the call_api call, and abandoning what I was doing.

@keslert
Copy link
Contributor

keslert commented Mar 30, 2020

Yes, it does. The biggest issue I had was that I was using the PHP sample code they provided and the order of parameters is reversed when using :crypto.hmac.

@dallagi
Copy link

dallagi commented Feb 7, 2021

Hi,

I'm not using this package, but I ran in the same problem while trying to authenticate some requests to the Product Advertising Api 5.

FYI I managed to successfully sign requests using the aws_auth package.

Just one note though: the version of that package from hex.pm won't work, as it has a bug that prevents it from working with the product advertising API.
I submitted a PR to fix it, and until it gets merged you can have a look at my fork here.

Hope this could be useful!

EDIT: I published a minimalistic library to build requests for the PAAPI5, you can find it here: https://github.com/dallagi/paapi5 . Feel free to take any code or inspiration from it, in case it may be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants