-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review process for new languages / big updates #117
Comments
If the PR is about a new functor, the process must be even more strict, because functors influence so many languages. |
Good suggestions Peter. These should be placed somewhere official, such as the main README, so that new contributors know what to expect (and for us to refer to). On this note, I am wary of using PRs a bit too superfluously. Specifically, updating a README like can surely just be committed directly into main by someone with write access. |
Of course. I mainly meant that large changes (new languages or big additions or substantial modification) should be PRs, so that it's possible to discuss. |
not only discuss, but also find out about the changes! |
When someone issues a new Pull Request, there should be an open and transparent review process before it's accepted. I suggest it consists of the following:
This is if the PR is a new language or a big update to an existing language. If there is small update (e.g., bug fix or additions to a lexicon), the process can be quicker.
The text was updated successfully, but these errors were encountered: