Fixed a bunch of Lint issues

Author: Brian Vaughn

.eslintignore

@@ -12,3 +12,10 @@ scripts/bench/benchmarks/**/*.js
 
 # React repository clone
 scripts/bench/remote-repo/
+
+packages/react-devtools-core/dist
+packages/react-devtools-extensions/chrome/build
+packages/react-devtools-extensions/firefox/build
+packages/react-devtools-extensions/shared/build
+packages/react-devtools-inline/dist
+packages/react-devtools-shell/dist

.gitignore

@@ -22,3 +22,14 @@ chrome-user-data
 .vscode
 *.swp
 *.swo
+
+packages/react-devtools-core/dist
+packages/react-devtools-extensions/chrome/build
+packages/react-devtools-extensions/chrome/*.crx
+packages/react-devtools-extensions/chrome/*.pem
+packages/react-devtools-extensions/firefox/build
+packages/react-devtools-extensions/firefox/*.xpi
+packages/react-devtools-extensions/firefox/*.pem
+packages/react-devtools-extensions/shared/build
+packages/react-devtools-inline/dist
+packages/react-devtools-shell/dist

.prettierignore

@@ -0,0 +1,6 @@
+packages/react-devtools-core/dist
+packages/react-devtools-extensions/chrome/build
+packages/react-devtools-extensions/firefox/build
+packages/react-devtools-extensions/shared/build
+packages/react-devtools-inline/dist
+packages/react-devtools-shell/dist

packages/react-devtools-core/src/backend.js

@@ -253,7 +253,7 @@ export function connectToDevTools(options: ?ConnectOptions) {
       }
     } catch (e) {
       console.error(
-        '[React DevTools] Failed to parse JSON: ' + String(event.data),
+        '[React DevTools] Failed to parse JSON: ' + (event.data: any),
       );
       return;
     }

packages/react-devtools-extensions/.eslintignore

@@ -1,5 +1,7 @@
 #!/usr/bin/env node
 
+'use strict';
+
 const archiver = require('archiver');
 const {execSync} = require('child_process');
 const {readFileSync, writeFileSync, createWriteStream} = require('fs');
@@ -28,23 +30,23 @@ const build = async (tempPath, manifestPath) => {
     '..',
     'node_modules',
     '.bin',
-    'webpack'
+    'webpack',
   );
   execSync(
     `${webpackPath} --config webpack.config.js --output-path ${binPath}`,
     {
       cwd: __dirname,
       env: process.env,
       stdio: 'inherit',
-    }
+    },
   );
   execSync(
     `${webpackPath} --config webpack.backend.js --output-path ${binPath}`,
     {
       cwd: __dirname,
       env: process.env,
       stdio: 'inherit',
-    }
+    },
   );
 
   // Make temp dir
@@ -56,7 +58,7 @@ const build = async (tempPath, manifestPath) => {
   await copy(binPath, join(zipPath, 'build'));
   await copy(manifestPath, copiedManifestPath);
   await Promise.all(
-    STATIC_FILES.map(file => copy(join(__dirname, file), join(zipPath, file)))
+    STATIC_FILES.map(file => copy(join(__dirname, file), join(zipPath, file))),
   );
 
   const commit = getGitCommit();

packages/react-devtools-extensions/.eslintrc

@@ -1,5 +1,7 @@
 #!/usr/bin/env node
 
+'use strict';
+
 const chalk = require('chalk');
 const {execSync} = require('child_process');
 const {existsSync} = require('fs');

packages/react-devtools-extensions/.flowconfig

@@ -1,5 +1,7 @@
 #!/usr/bin/env node
 
+'use strict';
+
 const deploy = require('../shared/deploy');
 
 const main = async () => await deploy('chrome');

packages/react-devtools-extensions/.gitignore

@@ -1,6 +1,8 @@
 #!/usr/bin/env node
 
-const chromeLaunch = require('chrome-launch'); // eslint-disable-line import/no-extraneous-dependencies
+'use strict';
+
+const chromeLaunch = require('chrome-launch');
 const {resolve} = require('path');
 
 const EXTENSION_PATH = resolve('shells/browser/chrome/build/unpacked');

packages/react-devtools-extensions/.prettierignore

@@ -1,5 +1,7 @@
 #!/usr/bin/env node
 
+'use strict';
+
 const {exec, execSync} = require('child_process');
 const {readFileSync, writeFileSync} = require('fs');
 const {join} = require('path');

packages/react-devtools-extensions/.prettierrc

@@ -1,5 +1,7 @@
 #!/usr/bin/env node
 
+'use strict';
+
 const chalk = require('chalk');
 const build = require('../shared/build');
 

packages/react-devtools-extensions/shared/build.js packages/react-devtools-extensions/build.js

@@ -1,5 +1,7 @@
 #!/usr/bin/env node
 
+'use strict';
+
 const deploy = require('../shared/deploy');
 
 const main = async () => await deploy('firefox');

packages/react-devtools-extensions/chrome/build.js

@@ -1,5 +1,7 @@
 #!/usr/bin/env node
 
+'use strict';
+
 const {exec} = require('child-process-promise');
 const {Finder} = require('firefox-profile');
 const {resolve} = require('path');

packages/react-devtools-extensions/chrome/deploy.js

@@ -1,5 +1,7 @@
 // @flow
 
+'use strict';
+
 declare var chrome: {
   devtools: {
     network: {

packages/react-devtools-extensions/chrome/test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 type JestMockFn<TArguments: $ReadOnlyArray<*>, TReturn> = {
   (...args: TArguments): TReturn,
   /**

packages/react-devtools-extensions/shared/deploy.chrome.html packages/react-devtools-extensions/deploy.chrome.html

@@ -4,6 +4,8 @@
 // Type definitions for react-test-renderer 16.x.x
 // Ported from: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-test-renderer
 
+'use strict';
+
 type ReactComponentInstance = React$Component<any>;
 
 type ReactTestRendererJSON = {

packages/react-devtools-extensions/shared/deploy.firefox.html packages/react-devtools-extensions/deploy.firefox.html

@@ -18,7 +18,6 @@ declare module 'node-events' {
 }
 
 declare var __DEV__: boolean;
-declare var __TEST__: boolean;
 
 declare var jasmine: {|
   getEnv: () => {|

packages/react-devtools-extensions/shared/deploy.html packages/react-devtools-extensions/deploy.html

@@ -1,5 +1,7 @@
 /* globals chrome */
 
+'use strict';
+
 document.addEventListener('DOMContentLoaded', function() {
   // Make links work
   const links = document.getElementsByTagName('a');

packages/react-devtools-extensions/shared/deploy.js packages/react-devtools-extensions/deploy.js

@@ -4,6 +4,8 @@
 
 /** @flow */
 
+'use strict';
+
 function welcome(event) {
   if (
     event.source !== window ||
@@ -51,7 +53,7 @@ function setup(hook) {
           payload: {event, payload},
         },
         '*',
-        transferable
+        transferable,
       );
     },
   });
@@ -66,12 +68,12 @@ function setup(hook) {
   initBackend(hook, agent, window);
 
   // Setup React Native style editor if a renderer like react-native-web has injected it.
-  if (!!hook.resolveRNStyle) {
+  if (hook.resolveRNStyle) {
     setupNativeStyleEditor(
       bridge,
       agent,
       hook.resolveRNStyle,
-      hook.nativeStyleEditorValidAttributes
+      hook.nativeStyleEditorValidAttributes,
     );
   }
 }

packages/react-devtools-extensions/firefox/build.js

@@ -1,5 +1,7 @@
 /* global chrome */
 
+'use strict';
+
 const ports = {};
 
 const IS_FIREFOX = navigator.userAgent.indexOf('Firefox') >= 0;
@@ -37,7 +39,7 @@ function installContentScript(tabId: number) {
   chrome.tabs.executeScript(
     tabId,
     {file: '/build/contentScript.js'},
-    function() {}
+    function() {},
   );
 }
 

packages/react-devtools-extensions/firefox/deploy.js

@@ -1,5 +1,7 @@
 /* global chrome */
 
+'use strict';
+
 let backendDisconnected: boolean = false;
 let backendInitialized: boolean = false;
 
@@ -9,7 +11,7 @@ function sayHelloToBackend() {
       source: 'react-devtools-content-script',
       hello: true,
     },
-    '*'
+    '*',
   );
 }
 
@@ -19,7 +21,7 @@ function handleMessageFromDevtools(message) {
       source: 'react-devtools-content-script',
       payload: message,
     },
-    '*'
+    '*',
   );
 }
 
@@ -48,12 +50,12 @@ function handleDisconnect() {
         event: 'shutdown',
       },
     },
-    '*'
+    '*',
   );
 }
 
 // proxy from main page to devtools (via the background page)
-var port = chrome.runtime.connect({
+const port = chrome.runtime.connect({
   name: 'content-script',
 });
 port.onMessage.addListener(handleMessageFromDevtools);

packages/react-devtools-extensions/firefox/test.js

@@ -85,5 +85,5 @@ if (sessionStorageGetItem(SESSION_STORAGE_RELOAD_AND_PROFILE_KEY) === 'true') {
 // Inject a `__REACT_DEVTOOLS_GLOBAL_HOOK__` global so that React can detect that the
 // devtools are installed (and skip its suggestion to install the devtools).
 injectCode(
-  ';(' + installHook.toString() + '(window))' + saveNativeValues + detectReact
+  ';(' + installHook.toString() + '(window))' + saveNativeValues + detectReact,
 );