-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New versions reflecting Node.js implementation #20
Comments
I think it will still be helpful if you folks can publish |
@harshzalavadiya We need to maintain support for Node.js v0.6 in context of a version v0.2 Concerning new breaking releases, as indicated I believe it's best to provide versions as listed in main description. I think it'll be good to maintain same test suite for all the versions, and as package is meant to reflect Node.js 1:1. To ensure best parity it's probably best to copy tests from Node.js repository -> https://github.com/nodejs/node/blob/master/test/parallel/test-querystring.js (still e.g. for v0.3 and v0.12 I would copy it from v0.12 version of Node.js etc). They depend on |
I thought it might be good to sort out this module, into something that most people would expect and find useful. Here's my proposal:
Let's publish multiple major versions:
v14 - Reflecting version in Node.js v14 (as 1:1 as it can be)
v12 - Reflecting version in Node.js v12 (as 1:1 as it can be)
v10 - Reflecting version in Node.js v10 (as 1:1 as it can be)
v0.12 - Reflecting version in Node.js v0.12 (as 1:1 as it can be). This would be the version safe to use in ES5 (non ES6) environments
v0.3 - ES3 version of v0.12, for those who expect ES3 support.
Version that reflects lowest Node.js version that still receives support, should be tagged as latest on npm (so it's installed by default). Currently it'll be v10
All versions should be maintained at it's own branches,
master
could lead to most recent (e.g.v14
at current time-being), but we could also makev14
as default branch instead.In all versions I would also expose package as one module (as it was originally here and as it is in Node.js).
PR's are welcome. Ideally each version should be proposed with different PR
The text was updated successfully, but these errors were encountered: