Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Replica::pending_tasks in TDB2::pending_tasks #3632

Closed
djmitche opened this issue Sep 27, 2024 · 0 comments · Fixed by #3661
Closed

Use new Replica::pending_tasks in TDB2::pending_tasks #3632

djmitche opened this issue Sep 27, 2024 · 0 comments · Fixed by #3661
Assignees
Milestone

Comments

@djmitche
Copy link
Collaborator

djmitche commented Sep 27, 2024

In GothenburgBitFactory/taskchampion#452, @Scandiravian created new Replica methods to return just the pending tasks, in an efficient single query.

Let's use that to implement TDB2::pending_tasks.

This will require a new release of TaskChampion before it lands. It's possible to start work on developing the patch before that something like

diff --git src/taskchampion-cpp/Cargo.toml src/taskchampion-cpp/Cargo.toml
index 91e557587..a7e0ad1ef 100644
--- src/taskchampion-cpp/Cargo.toml
+++ src/taskchampion-cpp/Cargo.toml
@@ -3,13 +3,13 @@ name = "taskchampion-lib"
 version = "0.1.0"
 edition = "2021"
 publish = false
 
 [lib]
 crate-type = ["staticlib"]
 
 [dependencies]
-taskchampion = "0.7.0"
+taskchampion = { path = "../../../taskchampion/taskchampion/" }
 cxx = "1.0.124"
 
 [build-dependencies]
 cxx-build = "1.0"

where the path points to https://github.com/GothenburgBitFactory/taskchampion/tree/main/taskchampion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant