-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing the video shows the thumbnail and the video embed #46
Comments
There's a bug in the demo, with I see that you recently edited this issue—in the initial version, were you using |
@jeffposnick, you are right: It was initially wrong but I corrected the snippet and the screenshots in the ticket. Problem is still there doe. |
I created a Pull Request that fixes this issue: #48 |
Is there any update on this? |
I added to the (stripped down) demo a button which allows changing the video:
Initially, the user sees the first thumbnail:
Clicking on the thumbnail starts the correct video:
After clicking the button to change the video, the new thumbnail is shown but the video embed is still visible:
I would expect to see only the new thumbnail. I would expect that the video embed is no longer in the DOM.
The text was updated successfully, but these errors were encountered: