Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throwing errors when app is saved to and accessed from iOS Home screen #142

Open
geoffdavis92 opened this issue Apr 6, 2016 · 3 comments
Labels

Comments

@geoffdavis92
Copy link

I am using google-signin in my app to check for credentials of the user, then allow/deny access to the main content. I am testing my app in several instances, and I saved my app to my iOS home screen using Safari.

When I am testing on desktop/mobile browser and hit the signin element, the browser opens a Google dialogue, which either auto-logs in or allows users to manually sign in, then closes and my app handles the outcome of that interaction.

After opening my app from my iPhone 6's Home Screen, I press the button to sign in and I am taken to a blank page; debugging returns the following issues:

Before pressing sign in button:

TypeError: null is not an object (evaluating 'this.$.getItem')

Stack trace: Issue stack trace

When I actually attempt to sign in, I get a blank screen and the following error message:

TypeError: null is not an object (evaluating 'this.c.setItem')

Stack trace: sign in dialogue stack trace

From what I can tell, the issue is with the google-signin element's use of sessionStorage which may or may not be supported by the browsing type; another potential issue is the sign-in dialogue not returning focus back to the app. (this may be due to the JS storage error)

@atotic
Copy link
Contributor

atotic commented Apr 11, 2016

It looks like an issue with google auth2 library. google-signin element does not directly use sessionStorage.
If you'd like to pursue this bug, you should file a bug with a reproducible case to the google auth2 library team.
https://github.com/google/google-api-javascript-client

@atotic atotic added the bug label Apr 11, 2016
@AlexanderSeto
Copy link

I'm experiencing the same issue. I've tried it with a single view application with only a WebView and this code in my viewDidLoad() function:
let url = URL (string: "https://example.com"); webView.scrollView.delegate = self let requestObj = URLRequest(url: url!); webView.loadRequest(requestObj);

screen shot 2016-10-04 at 10 23 34 pm

@geoffdavis92
Copy link
Author

@AlexanderSeto Is this for iOS as well? On Safari? I'm about to open an issue on the gAPI javascript page and want to be accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants