Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attribute native hidden and title in Polymer 2 #427

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kimagure44
Copy link

      Solved the failure in polymer 2 with the hidden attribute. 
       When you use the Google Maps component in Polymer 2 the hidden attribute is not working as in Polymer 1, 
       it only works the first time. 
       It seems that with the native attributes of html 'hidden', 'title', etc ... in polymer 2 in this 
       component they do not react to the change.I have reviewed the 'attributeChanged' method and it 
       appears as deprecated and according to the official documentation they recommend using 
       the 'attributeChangedCallback' method, but it behaves the same with the native attributes.
       I imagine that since they are native attributes they have a behavior that in polymer 1 if it worked 
       but in polymer 2 it does not do in binding.
       Solution: The first solution was to create a property that would replace the behavior of the hidden 
       or the title, but the final solution is much simpler. You have to declare the native 
       attributes 'hidden' or 'title' as properties of the component, in this way Native attributes 
       work correctly

          Solved the failure in polymer 2 with the hidden attribute. 
           When you use the Google Maps component in Polymer 2 the hidden attribute is not working as in Polymer 1, 
           it only works the first time. 
           It seems that with the native attributes of html 'hidden', 'title', etc ... in polymer 2 in this 
           component they do not react to the change.I have reviewed the 'attributeChanged' method and it 
           appears as deprecated and according to the official documentation they recommend using 
           the 'attributeChangedCallback' method, but it behaves the same with the native attributes.
           I imagine that since they are native attributes they have a behavior that in polymer 1 if it worked 
           but in polymer 2 it does not do in binding.
           Solution: The first solution was to create a property that would replace the behavior of the hidden 
           or the title, but the final solution is much simpler. You have to declare the native 
           attributes 'hidden' or 'title' as properties of the component, in this way Native attributes 
           work correctly
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@kimagure44
Copy link
Author

I signed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants