-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix click error due to undefined listener object #418
base: master
Are you sure you want to change the base?
Conversation
Checking if listeners is defined before accessing property and removing. Before setting new properties set empty object if it is undefined.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
Can you please merge this pr? Would be awesome. My app breaks due to this |
Almost 4 years later, this still seems to be an issue. Any chance of this getting merged? |
Checking if listeners is defined before accessing property and removing. Before setting new properties set empty object if it is undefined.
This is also noted in issue #407 . But does not include setting new listeners