Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icon type from Object to String #389

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change icon type from Object to String #389

wants to merge 1 commit into from

Conversation

fookoo
Copy link

@fookoo fookoo commented Aug 29, 2017

Allow to use google-map-marker with icon parameter passed as a string

<google-map-marker icon="/assets/icon.svg"></google-map-marker>

Before change you cant use string directly into tag attribute, you had to pass it as a bind property, like so:

<google-map-marker icon="{{ icon }}"></google-map-marker>

Allow to use google-map-marker with icon parameter passed as a string
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@fookoo
Copy link
Author

fookoo commented Sep 6, 2017 via email

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants