Added the loading
property to google-map-search
.
#370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I try to minimize the amount of Javascript that my elements need to function, and the lack
of a
loading
property ongoogle-map-search
forced me to do a lot more event handling thanI would have liked. So, I added one.
Essentially,
loading
defaults to false. It is set to true in thesearch
method, and itis set to false once again in the
_gotResults
method. It is updated beforegoogle-map-search-results
is fired, so that event will properly occur once all search actions are complete.
I also added a unit test around searching. I noticed that most of the tests won't run properly
without an
api-key
set on thegoogle-map
, so I guess that we'll all just have to insert ourown during testing? Kinda strange.
Anyway, this will now let you easily notify your users that a search is in progress. Previously,
this had to be done with a lot more hooks and events.