Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this.markers is set to readyOnly: true in the properties. this.marker… #354

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ZepAviator
Copy link

Fixes issue #353

markers property is set to readOnly and will throw an error if set directly.
this.markers = VALUE is incorrect.
this._setMarkers(VALUE) is correct.
Currently it is doing both and will fail in a strict mode.

…s = VALUE results in a setter error. _setMarkers(VALUE) is enough.

Fixes issue GoogleWebComponents#353
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ZepAviator
Copy link
Author

ZepAviator commented Feb 17, 2017 via email

@googlebot
Copy link

CLAs look good, thanks!

@JohnRiv
Copy link

JohnRiv commented Mar 29, 2018

Not sure why there's a conflict, but this change is required to be able get fit-to-markers to work. Can we get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants