Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for marker content update bug #295

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tst-dhudlow
Copy link
Contributor

See #286

@ebidel
Copy link
Contributor

ebidel commented May 3, 2016

Please add a test.

@ebidel
Copy link
Contributor

ebidel commented Jun 6, 2016

ping

@tst-dhudlow
Copy link
Contributor Author

When I run the current tests with polymer test I get a bunch of failures. (Timeouts and expected { Object (__gm, gm_accessors_, ...) } to equal undefined...). Can you point me to any docs on how to get these running so I can add?

@ebidel
Copy link
Contributor

ebidel commented Jun 15, 2016

Running them myself, it looks like there are errors. I can help get that working again.

Mind just adding a test for yourself?

@tst-dhudlow
Copy link
Contributor Author

Sure thing, I'll give it a shot. I just figured I was probably not configured correctly.

@tst-dhudlow
Copy link
Contributor Author

FYI, still working on reproducing this during tests. Having a bit of a time with it, but making progress.

@tst-dhudlow
Copy link
Contributor Author

Test created.

Note that this test will also pass with only changes to google-map-marker.html from #294

I still believe this change is logically correct though it may not technically be necessary after we hammer out #294.

@ebidel
Copy link
Contributor

ebidel commented Jul 5, 2016

TBH, I'm not sure about this change. Generally, hacking around timing issues like this means there's an underlying problem that needs to be addressed. In this case, #286 is using google-map-marker outside of google-map. That's not intended behavior.

@tst-dhudlow
Copy link
Contributor Author

Well, it's possible you're right that issues related to #294 are the real problem. I could try to verify this by tweaking the test, but it's my understanding that the issues is caused because when the marker is detached, its content is updated, and then it's re-attached, it doesn't update its content. Templates detach stuff from the DOM so they can be re-used and that's why this came up here.

The question is, do you want content to be updated if it is added/modified while the marker is in a detached state?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants