-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for marker content update bug #295
base: master
Are you sure you want to change the base?
Fix for marker content update bug #295
Conversation
Please add a test. |
ping |
When I run the current tests with |
Running them myself, it looks like there are errors. I can help get that working again. Mind just adding a test for yourself? |
Sure thing, I'll give it a shot. I just figured I was probably not configured correctly. |
FYI, still working on reproducing this during tests. Having a bit of a time with it, but making progress. |
TBH, I'm not sure about this change. Generally, hacking around timing issues like this means there's an underlying problem that needs to be addressed. In this case, #286 is using |
Well, it's possible you're right that issues related to #294 are the real problem. I could try to verify this by tweaking the test, but it's my understanding that the issues is caused because when the marker is detached, its content is updated, and then it's re-attached, it doesn't update its content. Templates detach stuff from the DOM so they can be re-used and that's why this came up here. The question is, do you want content to be updated if it is added/modified while the marker is in a detached state? |
See #286